feat: allow overriding mirrors via environment variables#287
Open
WoozyMasta wants to merge 2 commits into
Open
feat: allow overriding mirrors via environment variables#287WoozyMasta wants to merge 2 commits into
WoozyMasta wants to merge 2 commits into
Conversation
WoozyMasta
changed the title
WoozyMasta
changed the title
Collaborator
|
@WoozyMasta Thanks for your interest in the project and your proposition. As mentioned in #265 (comment), we still have to have the conversation internally regarding the approach we want to adopt to make this configurable before implementing anything. We would like to make sure it fits in a consistent approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds environment variable overrides for non-Pro Ubuntu archive URLs.
By default, behavior is unchanged. If no env vars are set, Chisel still uses:
http://archive.ubuntu.com/ubuntu/http://old-releases.ubuntu.com/ubuntu/http://ports.ubuntu.com/ubuntu-ports/Why
In some regions, access to default Ubuntu archive endpoints is unstable or slow.
Using nearby mirrors often improves reliability and speed (for example, selecting a mirror from
http://mirrors.ubuntu.com/UA.txt).Changes
archiveURL(...):CHISEL_UBUNTU_REPO_ARCHIVE_URLCHISEL_UBUNTU_REPO_OLD_RELEASES_URLCHISEL_UBUNTU_REPO_PORTS_URLTestArchiveURLFromEnv.README.md.Issues
Closes #265.
Potentially addresses #135.