Adapt CI to canonical/charm-ci#531
Draft
javierdelapuente wants to merge 12 commits into
Draft
Conversation
- Add artifacts.yaml generated by `opcli artifacts init` - Replace spread.yaml with opcli-generated version using the integration-test virtual backend and integration-suites for all four sub-charm test directories - Add concierge.yaml for LXD-based Juju test environment provisioning - Replace integration_test.yaml workflow with canonical/charm-ci reusable workflow (build-artifacts + integration-test) The previous workflow called canonical/operator-workflows; the new one delegates to canonical/charm-ci which uses opcli + spread to discover, build, and test artifacts declared in artifacts.yaml / spread.yaml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Replace invalid 'cwd' key with 'working-dir' in all per-charm suites - Set working-dir to each charm's sub-directory so pytest runs from the correct root (relative paths in conftest.py resolve correctly) - Add tests/integration/ suite for cross-charm tests requiring canonical-k8s - Create concierge-ck8s.yaml with LXD + canonical-k8s 1.32-classic/stable (k8s not bootstrapped as juju controller; conftest handles that itself) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
javierdelapuente
force-pushed
the
adapt-to-charm-ci
branch
from
88f8e4b to
8fb4d70
Compare
opcli passes --charm-file for all built charms; change action to 'append' and filter by charm name to avoid deploying the wrong charm. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…r tests" This reverts commit 005d707.
…s suite opcli passes all charm files by default; use pytest-arguments-template to restrict --charm-file to only haproxy-ddos-protection-configurator. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…emplate Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
build.path is relative to the project root (e.g. './built-charm-.../charm.charm') but pytest runs from haproxy-ddos-protection-configurator/ due to working-dir, so replace './' with '../' to make the path resolve correctly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Each suite now passes only its own charm file, avoiding cross-charm contamination and fixing the relative path issue introduced by working-dir. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tests Legacy tests under haproxy-operator/tests/integration/legacy/ use pytest-operator which unconditionally checks for charmcraft at startup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ion suite Replaces the operator-workflows pre-run-script. Runs as root (spread default) but delegates juju to the ubuntu user where concierge bootstrapped the controller. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Concierge was bootstrapping concierge-lxd while conftest bootstraps localhost, resulting in two controllers. Set bootstrap: false so concierge only installs LXD+Juju and the conftest manages its own localhost controller. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opcli artifacts initThe previous workflow called canonical/operator-workflows; the new one delegates to canonical/charm-ci which uses opcli + spread to discover, build, and test artifacts declared in artifacts.yaml / spread.yaml.
What this PR does
Why we need it
Checklist
docs/changelog.mdwith user-relevant changesdocs/release-notes/artifacts. If no change artifact is necessary, I tagged the PR with the labelno-release-note.(e.g., in
.github/workflows/integration_tests.yaml, ensure themoduleslist is correct)terraform fmtpasses andtflintreports no errors