fix(tests): correct the location of the Harness cleanup#1719
Draft
marceloneppel wants to merge 1 commit into
Draft
fix(tests): correct the location of the Harness cleanup#1719marceloneppel wants to merge 1 commit into
marceloneppel wants to merge 1 commit into
Conversation
test_get_extensions called cleanup() on the Harness before using it, so begin() and the assertion ran against an already-cleaned harness. This only worked because of a Harness bug that leaves a dangling sqlite3 reference; the fix for that bug (canonical/operator#2507) makes cleanup() tear down properly and breaks the test. Call cleanup() once the harness is finished with instead. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
github-actions
Bot
added
the
Libraries: Out of sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Solution
test_get_extensions called cleanup() on the Harness before using it, so begin() and the assertion ran against an already-cleaned harness. This only worked because of a Harness bug that leaves a dangling sqlite3 reference; the fix for that bug (canonical/operator#2507) makes cleanup() tear down properly and breaks the test. Call cleanup() once the harness is finished with instead.
Checklist
Port of canonical/postgresql-k8s-operator#1551.