snap: fix s390x build of wheel-less Python dependencies#198
Merged
Conversation
Author
|
Confirmed that this builds on an s390x LPAR: |
gboutry
approved these changes
Jun 24, 2026
gboutry
requested changes
Jun 24, 2026
gboutry
left a comment
gboutry
left a comment
Collaborator
There was a problem hiding this comment.
Can you reword your commit to replace co-authored-by with assisted-by, and add signed-off-by?
On architectures without published wheels (notably s390x), uv builds cryptography, markupsafe, msgpack and psutil from sdist. Two things broke those source builds: - Python.h was missing. uv creates its venv from this part's *staged* interpreter, so the headers must be in the staged Python tree; a python3-dev build-package does not reach it. Stage libpython3-dev. - cryptography 41.0.7's setuptools-rust backend imports pkg_resources, which setuptools >= 81 removed. uv sync ignores UV_BUILD_CONSTRAINT, so pin its build-time setuptools < 81 via [tool.uv.extra-build-dependencies], which uv sync honors. Verified by a native s390x snapcraft build. Assisted-by: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Myles Penner <myles.penner@canonical.com>
MylesJP
force-pushed
the
fix/s390x-source-builds
branch
from
June 24, 2026 21:03
494ce9a to
b646059
Compare
Author
Thanks, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On architectures without published wheels (notably s390x), uv builds cryptography, markupsafe, msgpack and psutil from sdist. Two things broke those source builds:
Verified by a native s390x snapcraft build.