Allow passing initial model configuration#516
Merged
hemanthnakkina merged 1 commit intoJun 13, 2025
Conversation
For the model created by Sunbeam, allow passing initial model configuration. The only guarantee made is that, at creation time, the parameter will be given to juju, and only if Sunbeam does not override them. Sunbeam will not perform any checks to see wheter or not these config options are valid parameter. Closes-Bug: #2065490 Signed-off-by: Guillaume Boutry <guillaume.boutry@canonical.com>
gboutry
marked this pull request as draft
June 13, 2025 10:08
gboutry
marked this pull request as ready for review
June 13, 2025 10:13
hemanthnakkina
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the model created by Sunbeam, allow passing initial model configuration. The only guarantee made is that, at creation time, the parameter will be given to juju, and only if Sunbeam does not override them. Sunbeam will not perform any checks to see wheter or not these config options are valid parameter.
Closes-Bug: #2065490