Skip to content

Fix to apply custom region for microceph (S3 and Swift) endpoints#518

Merged
gboutry merged 3 commits into
canonical:mainfrom
suvidyam29:fix/microceph_region
Jun 17, 2025
Merged

Fix to apply custom region for microceph (S3 and Swift) endpoints#518
gboutry merged 3 commits into
canonical:mainfrom
suvidyam29:fix/microceph_region

Conversation

@suvidyam29

Copy link
Copy Markdown

This PR fixes a bug (https://bugs.launchpad.net/snap-openstack/+bug/2109812) where custom region names provided via the manifest file were not reflected in the S3 and Swift service endpoints, which defaulted to "RegionOne".

What was changed?

  1. Imported read_config from sunbeam.core.common in microceph.py.
  2. Defined constants (REGION_CONFIG_KEY, DEFAULT_REGION) in microceph.py.
  3. Dynamically fetch the configured region for the RGW service in microceph.py.

@suvidyam29
suvidyam29 force-pushed the fix/microceph_region branch from 8534124 to c97ef47 Compare June 16, 2025 13:28

@gboutry gboutry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thanks for the PR, this will help!

Comment thread sunbeam-python/sunbeam/steps/microceph.py Outdated
@suvidyam29
suvidyam29 force-pushed the fix/microceph_region branch from 62e6328 to aa771a6 Compare June 16, 2025 18:49
@hemanthnakkina

Copy link
Copy Markdown
Collaborator

@suvidyam29 Can you sign the commits

@suvidyam29

Copy link
Copy Markdown
Author

@suvidyam29 Can you sign the commits

Signed commits.

@suvidyam29
suvidyam29 requested a review from gboutry June 17, 2025 04:57

@hemanthnakkina hemanthnakkina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@gboutry
gboutry merged commit 5f2c6ff into canonical:main Jun 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants