Add Sunbeam TLS Vault Feature#520
Merged
Merged
Conversation
fabi200123
force-pushed
the
tls-vault-feature
branch
from
June 23, 2025 08:44
f18a747 to
7954092
Compare
fabi200123
force-pushed
the
tls-vault-feature
branch
5 times, most recently
from
July 14, 2025 00:32
1253650 to
d974fdb
Compare
fabi200123
changed the title
fabi200123
force-pushed
the
tls-vault-feature
branch
3 times, most recently
from
July 14, 2025 09:40
e42c9e7 to
05dcff6
Compare
Add prompt for external_hostnames for traefik endpoints during bootstrap
fabi200123
force-pushed
the
tls-vault-feature
branch
from
July 15, 2025 13:12
05dcff6 to
86a0017
Compare
hemanthnakkina
approved these changes
Jul 16, 2025
hemanthnakkina
left a comment
hemanthnakkina
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, can you use unit names instead of relation id's in list_outstanding_csrs? This can be a subsequent PR
Member
|
The new question blocks non-TLS deployment scenarios. https://bugs.launchpad.net/snap-openstack/+bug/2119425 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the TLS Vault feature, which allows the operator to configure Vault (Vault-k8s charm) as an Intermediary CA.
NOTE: This PR should not be merged until the following steps are finished:
1/edgecommon_nameconfiguration for Vault andexternal_hostnamefor Traefik endpoints are properly definedNOTE 2: This PR adds breaking changes unless the PR from sunbeam-terraform is merge
NOTE 3: This PR requires the following PR to be merged inside sunbeam-terraform for keeping 3 different tfvars for traefik endpoints