Fix/lp 2158343 invalid backend names#870
Merged
gboutry merged 3 commits intoJul 2, 2026
Merged
Conversation
Changed the overly strict digit check from: if any(char.isdigit() for char in last_part): to: if last_part.isdigit(): This now only rejects names where the segment after the final hyphen is entirely numeric (like my-app-1), which would conflict with Juju's unit naming scheme. Names like my-hpe3par where the last segment contains a mix of letters and digits are now correctly accepted.
hmlanigan
reviewed
Jun 30, 2026
Use the standard JUJU pattern Co-authored-by: hmlanigan <heather.lanigan@canonical.com>
gboutry
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
The check in sunbeam-python/sunbeam/storage/base.py:91 is overly strict:
This rejects any name where the last segment (after the final hyphen) contains any digit character. For my-hpe3par, it splits to
["my", "hpe3par"]and the last part "hpe3par" contains the digit 3, so it's rejected.The fix is a one-line change in sunbeam-python/sunbeam/storage/base.py:91:
I have also added the related tests in tox