Fix traefik tls certs during refresh#879
Open
Thanhphan1147 wants to merge 3 commits into
Open
Conversation
Thanhphan1147
marked this pull request as ready for review
July 10, 2026 05:29
Thanhphan1147
force-pushed
the
fix-traefik-tls-certs
branch
from
July 10, 2026 05:44
53ec740 to
f8b7da7
Compare
Thanhphan1147
changed the title
hmlanigan
reviewed
Jul 13, 2026
hmlanigan
left a comment
hmlanigan
left a comment
There was a problem hiding this comment.
Question: how do we test this charnge?
Thanhphan1147
force-pushed
the
fix-traefik-tls-certs
branch
from
July 16, 2026 01:07
a3aa757 to
da500d4
Compare
gboutry
requested changes
Jul 16, 2026
Thanhphan1147
force-pushed
the
fix-traefik-tls-certs
branch
from
July 16, 2026 13:20
186ebae to
c08b31d
Compare
Author
|
@Raven-182 I squashed all commits into 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release of traefik revision 281 introduces managing certificates in "APP" mode. However, due to an issue with the tls-certiicates library, the corresponding private_key did not had the correct scope, which introduce a risk of service disruption . This PR proposes a fix so that deployments that are in a "degraded" state can self-heal after running the
sunbeam refreshcommand.The PR adds a custom logic towards the end of the
refreshcommand to find outstanding CSRs, check that the subject matches the certificates stored in_CONFIG, then rerunprovide-certifcateaction onmanual-tls-certificatesWe considered a few options:
sunbeam fix-certsfor example )sunbeam refresh --fix-certs)This PR implements option 3 to simplify user UX.
Assisted-By: copilot
Related-PR: https://github.com/canonical/traefik-k8s-operator/pull/729/changes
Related-bug: canonical/traefik-k8s-operator#709
QA steps