Skip to content

Enable session signing keys on KMS integration tests#5835

Draft
martinflorian-da wants to merge 1 commit into
mainfrom
martinflorian-da/hls-5135-enable-session-signing-keys-kms-tests
Draft

Enable session signing keys on KMS integration tests#5835
martinflorian-da wants to merge 1 commit into
mainfrom
martinflorian-da/hls-5135-enable-session-signing-keys-kms-tests

Conversation

@martinflorian-da

Copy link
Copy Markdown
Contributor

Part of #5135

Holding off merge until PV35 is the default, so we don't need to hard-code the PV in that test.

[ci]

Signed-off-by: Martin Florian martin.florian@digitalasset.com

Part of #5135

Holding off merge until PV35 is the default, so we don't need to hard-code the PV in that test.

[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
@moritzkiefer-da

Copy link
Copy Markdown
Contributor

Holding off merge until PV35 is the default, so we don't need to hard-code the PV in that test.

Mostly recording this so it doesn't get lost: The problem is not that PV 35 is not the default, it is in integration tests. What will be a problem is the daily compat tests againt PV 34. So you either need to exclude it from those or wait until they are gone (after mainnet is PV 35)

@martinflorian-da

Copy link
Copy Markdown
Contributor Author

Mostly recording this so it doesn't get lost: The problem is not that PV 35 is not the default, it is in integration tests.

Not if we do .clearConfigTransforms(), which is what we do here.

What will be a problem is the daily compat tests againt PV 34. So you either need to exclude it from those or wait until they are gone (after mainnet is PV 35)

Ah yes, I missed that...

@martinflorian-da

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants