Skip to content

fix: normalize urls for config#1882

Open
PHOL-DA wants to merge 2 commits into
mainfrom
phol/nor
Open

fix: normalize urls for config#1882
PHOL-DA wants to merge 2 commits into
mainfrom
phol/nor

Conversation

@PHOL-DA

@PHOL-DA PHOL-DA commented May 26, 2026

Copy link
Copy Markdown
Contributor

Problem
Some times people expect default behavior when inserting string urls in config, for instance they might insert localhost:8080 instead of http://localhost:8080 or they might insert my-domain.com instead of http://my-domain.com.

Solution
This pr addresses default behavior, defined as:

  • if using http and no port, then use port 80
  • if using https and no port, then use port 443
  • if no transport is provided use http

PHOL-DA added 2 commits May 26, 2026 14:38
Signed-off-by: phillip olesen <phillip.olesen@digitalasset.com>
Signed-off-by: phillip olesen <phillip.olesen@digitalasset.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant