[RBSALSIS-697]: ALS NG CAP Java Plugin - Audit Logging for Support User Impersonation - #131
Open
georgi-shakev wants to merge 10 commits into
Open
[RBSALSIS-697]: ALS NG CAP Java Plugin - Audit Logging for Support User Impersonation#131georgi-shakev wants to merge 10 commits into
georgi-shakev wants to merge 10 commits into
Conversation
… in the common section of the event.
…ser functionality from userInfo.
![hyperspace-pr-bot[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR introduces v2 audit event format support with SAP support user impersonation context. The code is generally well-structured, but there are a few correctness issues: formatEventTypeToV2 can throw StringIndexOutOfBoundsException on short/empty event types, createGeneralEventDataNode can have framework-set fields silently overwritten by caller-supplied event data, and the test schema cache uses a non-thread-safe HashMap. The unnecessary two-line variable split in AuditLogNGCommunicator is also flagged for clarity.
PR Bot Information
Version: 1.29.2
- LLM:
anthropic--claude-4.6-sonnet - Experiment Variant:
control - Event Trigger:
issue_comment.created - File Content Strategy: Full file content
- Correlation ID:
f05052e0-89c3-11f1-9c72-3a6f8b5c94ed
…required version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.