Add Integration Testing on ANS Service and HANA#138
Conversation
There was a problem hiding this comment.
The PR is generally well-structured, adding hybrid testing support and reorganizing tests into logical describe groups. The main concerns are: the require placement for the HTTP client mock inside a describe block in the unit tests (fragile under module reset scenarios), and the intentional-but-undocumented behavioral change of always populating cds.notifications.local.types in production when kind === 'notify-to-rest', which previously was skipped. Please verify the production exposure of local type data is intentional before merging.
PR Bot Information
Version: 1.26.11
- LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
- Event Trigger:
pull_request.opened - Correlation ID:
e84ef2b9-3f9c-40c2-bc00-2a231c6bf562
SummaryThe following content is AI-generated and provides a summary of the pull request: Add Hybrid Testing Support for ANS Service and Refactor Integration TestsNew Features✨ Introduces hybrid testing support, allowing integration tests to run against real ANS/HANA services (via Changes
PR Bot InformationVersion:
|
There was a problem hiding this comment.
The PR introduces hybrid integration testing support with good overall structure. The main concerns are: "production" being folded into the isHybrid flag (misleading name and potentially wrong behavior), and cds.notifications now being populated unconditionally for all service kinds/environments where it was previously guarded — both of which should be explicitly confirmed as intentional.
PR Bot Information
Version: 1.26.11
- LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
b7fd14a5-3040-482e-837b-00d36ef04115 - Event Trigger:
pull_request.ready_for_review - File Content Strategy: Full file content
Hybrid testing is now supported. Some bugs were discovered in testing that were also adjusted and integration tests were re-worked.