feat: display liquidation price line on trading chart (fixes #7)#205
Open
jiangyj545 wants to merge 2 commits into
Open
feat: display liquidation price line on trading chart (fixes #7)#205jiangyj545 wants to merge 2 commits into
jiangyj545 wants to merge 2 commits into
Conversation
added 2 commits
May 25, 2026 12:09
…ial#7) - Add showLiqPriceOnChart setting (default: off, toggle in Settings) - Show dashed red price line at liquidation price per position - Uses lightweight-charts createPriceLine with axis label - Filters by selected market, skips positions without liqprice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7: Add optional liquidation price display on the trading chart as a dashed red price line.
Problem
Users can see orders and positions on the chart, but cannot visualize their liquidation price — a critical risk metric.
Solution
Added a "Liquidation price on chart" toggle in Account Settings (default: off). When enabled:
showOrdersOnChart/showPositionsOnChartChanges
src/lib/stores.jsshowLiqPriceOnChartwritable store (default: false)src/lib/chart.jsloadLiqPriceLines()+clearLiqPriceLines()usingcreatePriceLine()with dashed red stylesrc/components/modals/Settings.svelteTechnical Details
lightweight-chartscreatePriceLine()API (same as orders/positions)LineStyle.Dashed, color:#FF2D00(red), lineWidth: 1selectedMarket— only shows liq prices for visible marketliqpricesaveUserSetting()/ localStorageBuild verified:
npx rollup -c✅