[ShanaBoo] Display more information when depositing/withdrawing from pools#213
Open
genesisrevelationinc-debug wants to merge 12 commits into
Open
[ShanaBoo] Display more information when depositing/withdrawing from pools#213genesisrevelationinc-debug wants to merge 12 commits into
genesisrevelationinc-debug wants to merge 12 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new Svelte modal component intended to support depositing (and currently also includes withdrawing) with a “click balance to set max” interaction.
Changes:
- Introduces
DepositModal.sveltewith deposit UI and balance “set max” behavior. - Adds modal styling for balance row/value display.
- Includes an additional withdraw modal block in the same file (appears unintended).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+17
to
+19
| <style> | ||
|
|
||
| <Modal title='Deposit' show={showModal} on:close={closeModal}> |
| <Button on:click={submit} isLoading={isSubmitting}>Deposit</Button> | ||
| </Modal> | ||
|
|
||
| <style> |
| @@ -0,0 +1,102 @@ | |||
| <script> | |||
Comment on lines
+8
to
+9
| } | ||
| } |
Comment on lines
+52
to
+54
| <script> | ||
| import { onMount } from 'svelte'; | ||
| import { withdraw } from '../../lib/pool'; |
| <span class='balance-value' on:click={setMaxAmount}>{$balance ? $balance.toFixed(6) : '0.000000'}</span> | ||
| </div> | ||
|
|
||
| <Input label='Amount' type='number' bind:value={amount} /> |
|
|
||
| <div class='balance-row'> | ||
| <span class='label'>Wallet Balance</span> | ||
| <span class='balance-value' on:click={setMaxAmount}>{$balance ? $balance.toFixed(6) : '0.000000'}</span> |
Comment on lines
+11
to
+13
| function setMaxAmount() { | ||
| amount = $balance; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShanaBoo Autonomous Fix
This PR was automatically generated by ShanaBoo Earn Engine to claim the $50.00 bounty on this issue.
Source: Github | Task: 1482928727
Closes #23
Auto-submitted by ShanaBoo CNS — NVIDIA NIM + Microsoft Agent Framework