Skip to content

fix(release): bound notarytool --wait so a stuck submission can't eat the whole CI budget #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barscn merged 1 commit into from
Jul 7, 2026
Merged

fix(release): bound notarytool --wait so a stuck submission can't eat the whole CI budget #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ jobs:
release:
name: Sign, notarize & publish
runs-on: macos-26
# Backstop the per-step notarytool --timeout: if any step wedges, fail at ~1h rather than
# letting the run idle to GitHub's 6-hour hard limit (which a stuck notarization once did).
timeout-minutes: 60
env:
DEVELOPER_DIR: /Applications/Xcode.app/Contents/Developer
TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
Expand Down
7 changes: 6 additions & 1 deletion Scripts/release/notarize.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,14 @@ log "Zipping app for notarization → $SUBMIT_ZIP"
run ditto -c -k --keepParent "$APP" "$SUBMIT_ZIP"

log "Submitting to the notary service (this can take a few minutes)…"
# --timeout bounds the --wait poll. A healthy submission clears in minutes, but Apple's notary
# service can occasionally wedge a submission "In Progress" indefinitely; without a bound, --wait
# blocks until the CI job itself is killed (a stuck run once burned GitHub's full 6-hour budget).
# Fail fast at 30m so the release errors loudly instead of idling to the runner's hard ceiling.
run xcrun notarytool submit "$SUBMIT_ZIP" \
--keychain-profile "$NOTARY_PROFILE" \
--wait
--wait \
--timeout 30m

log "Stapling the notarization ticket onto the app"
run xcrun stapler staple "$APP"
Expand Down
Loading