Skip to content

add support for datalinks other than ethernet#145

Draft
drunkirishcoder wants to merge 18 commits intodjin/0.2.0-alphafrom
djin/datalink
Draft

add support for datalinks other than ethernet#145
drunkirishcoder wants to merge 18 commits intodjin/0.2.0-alphafrom
djin/datalink

Conversation

@drunkirishcoder
Copy link
Copy Markdown
Contributor

@drunkirishcoder drunkirishcoder commented Jan 8, 2022

Description

Add a trait Datalink that makes it possible to support a different datalink for IP packets. The only other applicable datalink supported by DPDK is InfiniBand through Mellanox NICs. #144

This is a breaking change. Previously it was assumed that IP packets (both v4 and v6) will only be encapsulated inside an Ethernet frame, which is the overwhelming majority of the use case of DPDK. After the change, the struct becomes a generic struct, Ipv4<E: Datalink>.

Type of change

  • Bug fix
  • New feature
  • New protocol
  • Breaking change
  • Documentation update

Checklist

  • Associated tests
  • Associated documentation

@drunkirishcoder drunkirishcoder changed the title add support for datalink other than ethernet add support for datalinks other than ethernet Jan 8, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2022

Codecov Report

❌ Patch coverage is 70.14634% with 306 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.44%. Comparing base (87ecc82) to head (b1e9b9d).
⚠️ Report is 10 commits behind head on djin/0.2.0-alpha.

Files with missing lines Patch % Lines
core/src/runtime/port.rs 59.46% 107 Missing ⚠️
core/src/runtime/mod.rs 12.85% 61 Missing ⚠️
core/src/runtime/pcap_dump.rs 39.75% 50 Missing ⚠️
core/src/runtime/lcore.rs 58.00% 21 Missing ⚠️
core/src/packets/size_of.rs 0.00% 14 Missing ⚠️
core/src/testils/proptest/strategy.rs 39.13% 14 Missing ⚠️
core/src/runtime/config.rs 77.58% 13 Missing ⚠️
core/src/runtime/mempool.rs 82.97% 8 Missing ⚠️
core/src/testils/packet.rs 27.27% 8 Missing ⚠️
core/src/packets/icmp/v4/echo_reply.rs 71.42% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@                 Coverage Diff                  @@
##           djin/0.2.0-alpha     #145      +/-   ##
====================================================
+ Coverage             68.40%   76.44%   +8.04%     
====================================================
  Files                    66       50      -16     
  Lines                  5972     5048     -924     
====================================================
- Hits                   4085     3859     -226     
+ Misses                 1887     1189     -698     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drunkirishcoder drunkirishcoder changed the base branch from master to djin/0.2.0-alpha January 9, 2022 23:19
@zeeshanlakhani zeeshanlakhani self-requested a review January 10, 2022 11:02
@drunkirishcoder drunkirishcoder force-pushed the djin/0.2.0-alpha branch 2 times, most recently from 8e818aa to 74ab2b5 Compare February 26, 2022 03:48
@drunkirishcoder drunkirishcoder force-pushed the djin/0.2.0-alpha branch 2 times, most recently from bffcbb9 to 1232a4c Compare September 27, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant