Newly revamped method for basic visualization#1339
Open
0x5066 wants to merge 5 commits into
Open
Conversation
All good things are 3... ... Except for Winamp3. This entirely revamps how Webamp performs its basic visualization (because that is apparently *very* difficult...). All of this was based on research and decompilation from Winamp 2.63, the way the oscilloscope and spectrum analyzer are drawn, including their different coloring modes (analyzer's Normal, Fire and Line modes, oscilloscope's Dots, Lines and Solid modes) are 100% matched. The intent behind this new commit and PR is to remove the old way of doing things (VisPainter), while it served us well, maintainability became difficult as time went on (partly because of the way it was written and how additions were made), as things were more based on observation rather than truly fact checking how it actually works. Fixes the following: - Polarity of the Oscilloscope is no longer inverted.
✅ Deploy Preview for tourmaline-kringle-c98715 canceled.
|
Reverted the analyzer coloring back to "normal"
That was painful...
Contributor
Author
|
I will note, that there is an issue currently with the playlist editor's visualizer, where the state isn't preserved when the main window is re-enabled again. Main Window -> disabled -> automatically switches to the playlist one, where the state is preserved (watch the peaks still at the top), but when Main Window -> re-enabled, the visualizer seems to be recreated for some reason, and from what I attempted seems more work than necessary for this PR to address. The state of the visualizer is preserved when you switch modes (to/from windowshade, to/from doublesize) however. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All good things are 3...
... Except for Winamp3.
This entirely revamps how Webamp performs its basic visualization (because that is apparently very difficult...).
All of this was based on research and decompilation from Winamp 2.63, the way the oscilloscope and spectrum analyzer are drawn, including their different coloring modes (analyzer's Normal, Fire and Line modes, oscilloscope's Dots, Lines and Solid modes) are 100% matched.
The intent behind this new commit and PR is to remove the old way of doing things (VisPainter), while it served us well, maintainability became difficult as time went on (partly because of the way it was written and how additions were made), as things were more based on observation rather than truly fact checking how it actually works.
Fixes the following: