ci: Do not manually search for OpenCV dependency#311
Merged
ethanmusser merged 2 commits intoJun 22, 2026
Conversation
ethanmusser
changed the title
find_package(OpenCV) call
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mattalvarado
approved these changes
Jun 22, 2026
ethanmusser
deleted the
ethanmusser/310-library-consumption-test-no-find-opencv
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a now-outdated practice in the CI's library consumer test fixture CMake that would manually attempt to find the OpenCV target if it was not available. This was a holdover from before a fix for this issue was implemented via #299. Now, OpenCV will be automatically searched for via the package configuration file's
find_dependency()calls.Resolves #310.