Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

feat: Add support for global env registry in kvisor#709

Merged
oanatmaria merged 1 commit into
mainfrom
CID-616/add-global-registry-env-var
May 6, 2026
Merged

feat: Add support for global env registry in kvisor#709
oanatmaria merged 1 commit into
mainfrom
CID-616/add-global-registry-env-var

Conversation

@oanatmaria

@oanatmaria oanatmaria commented May 5, 2026

Copy link
Copy Markdown
Contributor

Kimchi Summary

What changed

Adds support for a global container registry override via global.registry value. All image references across the chart now use a new helper template that prepends the global registry when set, enabling centralized registry configuration.

Why

Enables deployment in air-gapped environments or with private registry mirrors without manually overriding each individual image repository.

Key changes

  • Added kvisor.imageRepository helper in _helpers.tpl to resolve image repositories with optional global.registry prefix
  • Updated charts/kvisor/templates/agent.yaml to use helper for gpu-feature-discovery, kvisor, obi, otel-collector, and dcgm-exporter containers
  • Updated charts/kvisor/templates/cast-mock-server.yaml to use helper for the generator container
  • Updated charts/kvisor/templates/clickhouse.yaml to use helper for schema and storage containers
  • Updated charts/kvisor/templates/controller.yaml to use helper for controller and otel-collector containers
  • Updated charts/kvisor/templates/event-generator.yaml to use helper for the generator container

Impact

Backward compatible: if global.registry is unset, images resolve to their original repositories. Set global.registry (e.g., my-registry.io/castai) to prefix all images automatically.

@kimchi-review

kimchi-review Bot commented May 5, 2026

Copy link
Copy Markdown

Kimchi Code Review

Property Value
Commit 9980b30
Author @oanatmaria
Files changed 0
Review status Completed
Comments 0
Duration 15s

Summary

📊 Review Score: 92/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 2/5 (1 = trivial, 5 = very complex)

🧪 Tests: no — No automated tests are included in the diff for the new Helm template logic. Consider adding helm-unittests or verifying with helm template --set global.registry=... to ensure the registry prefixing works correctly across all image references.

No significant issues found. LGTM! 🎉

What to expect

Kimchi will analyze the changes in this pull request and post:

  • A summary of the overall changes
  • Inline comments on specific lines with findings categorized by issue type

The review typically completes within a few minutes. This comment will be updated once the review is ready.

Interact with Kimchi
  • @kimchi review — re-trigger a full review on the latest commit
  • @kimchi summary — regenerate the PR summary
  • @kimchi ignore — skip this PR (no review will be posted)
  • Reply to any inline comment to ask follow-up questions or request clarification
Configuration

Reviews are configured by your organization admin.
Review instructions, excluded directories, and severity thresholds can be adjusted per repository in the Kimchi dashboard.


Powered by Kimchi — AI-powered code review by CAST AI

@kimchi-review kimchi-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📊 Review Score: 92/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 2/5 (1 = trivial, 5 = very complex)

🧪 Tests: no — No automated tests are included in the diff for the new Helm template logic. Consider adding helm-unittests or verifying with helm template --set global.registry=... to ensure the registry prefixing works correctly across all image references.

No significant issues found. LGTM! 🎉

@oanatmaria oanatmaria changed the title CID-616: Add support for global env registry in kvisor feat: Add support for global env registry in kvisor May 6, 2026
@oanatmaria oanatmaria merged commit d575a62 into main May 6, 2026
3 checks passed
@oanatmaria oanatmaria deleted the CID-616/add-global-registry-env-var branch May 6, 2026 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants