feat: Add support for global env registry in kvisor#709
Conversation
Kimchi Code Review
Summary📊 Review Score: 92/100 (overall code quality — 0 lowest, 100 highest) 🧪 Tests: no — No automated tests are included in the diff for the new Helm template logic. Consider adding helm-unittests or verifying with No significant issues found. LGTM! 🎉 What to expectKimchi will analyze the changes in this pull request and post:
The review typically completes within a few minutes. This comment will be updated once the review is ready. Interact with Kimchi
ConfigurationReviews are configured by your organization admin. Powered by Kimchi — AI-powered code review by CAST AI |
There was a problem hiding this comment.
📊 Review Score: 92/100 (overall code quality — 0 lowest, 100 highest)
⏱️ Estimated effort to review: 2/5 (1 = trivial, 5 = very complex)
🧪 Tests: no — No automated tests are included in the diff for the new Helm template logic. Consider adding helm-unittests or verifying with helm template --set global.registry=... to ensure the registry prefixing works correctly across all image references.
No significant issues found. LGTM! 🎉
Kimchi Summary
What changed
Adds support for a global container registry override via
global.registryvalue. All image references across the chart now use a new helper template that prepends the global registry when set, enabling centralized registry configuration.Why
Enables deployment in air-gapped environments or with private registry mirrors without manually overriding each individual image repository.
Key changes
kvisor.imageRepositoryhelper in_helpers.tplto resolve image repositories with optionalglobal.registryprefixcharts/kvisor/templates/agent.yamlto use helper forgpu-feature-discovery,kvisor,obi,otel-collector, anddcgm-exportercontainerscharts/kvisor/templates/cast-mock-server.yamlto use helper for the generator containercharts/kvisor/templates/clickhouse.yamlto use helper forschemaandstoragecontainerscharts/kvisor/templates/controller.yamlto use helper forcontrollerandotel-collectorcontainerscharts/kvisor/templates/event-generator.yamlto use helper for the generator containerImpact
Backward compatible: if
global.registryis unset, images resolve to their original repositories. Setglobal.registry(e.g.,my-registry.io/castai) to prefix all images automatically.