Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
dotnet-version: |
8.0.x
9.0.x
10.0.x

# -----
# Build
Expand Down
10 changes: 10 additions & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ for:
only:
- image: Ubuntu2204

# install .NET 10 SDK
install:
- curl -L https://dot.net/v1/dotnet-install.sh -o dotnet-install.sh
- chmod +x ./dotnet-install.sh
- sudo ./dotnet-install.sh --channel 10.0 --install-dir /usr/share/dotnet

# build and run tests
build_script:
- uname -a
Expand Down Expand Up @@ -46,6 +52,10 @@ for:
Update-AppveyorBuild -Version ($env:APPVEYOR_REPO_TAG_NAME).TrimStart("v")
}

# install .NET 10 SDK
install:
- cmd: choco install dotnet-10.0-sdk

# build and run tests
build_script:
- cmd: build.cmd
Expand Down
2 changes: 1 addition & 1 deletion buildscripts/common.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<PropertyGroup>
<LangVersion>13.0</LangVersion>
<LangVersion>14.0</LangVersion>
<NoWarn>$(NoWarn);CS1591;CS3014;CS3003;CS3001;CS3021</NoWarn>
<NoWarn>$(NoWarn);CS0612;CS0618</NoWarn> <!-- TODO: Remove this line once `[Obsolete]` members have been dealt with. -->
<RepositoryType>git</RepositoryType>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public void ReflectionReturnsCorrectModoptOnParamTypeForGeneratedType(string typ

var modopts = this.generatedTypes[typeName].GetMethod("Foo").GetParameters()[0].GetOptionalCustomModifiers();

CollectionAssert.AreEqual(expected: CustomModifiersTestCase.customModifiers[typeNameWithoutSuffix].Reverse(), actual: modopts);
CollectionAssert.AreEqual(expected: Enumerable.Reverse(CustomModifiersTestCase.customModifiers[typeNameWithoutSuffix]), actual: modopts);
Comment thread
stakx marked this conversation as resolved.
// ^ The emission of custom modifiers performed by DynamicProxy is currently geared towards
// the CLR, which reports custom modifiers in reverse order. On Mono, before version 5.16,
// Reflection would not report custom modifiers at all; this has now changed. But unlike the
Expand Down Expand Up @@ -183,7 +183,7 @@ public void ReflectionReturnsCorrectModreqsOnParamTypeForGeneratedType(string ty
var modreqs = this.generatedTypes[typeName].GetMethod("Foo").GetParameters()[0].GetRequiredCustomModifiers();
Assume.That(modreqs.Length > 0); // If this fails on mono/linux we have to revisit the commits and issues for IL method custom modifiers. https://github.com/castleproject/Core/issues/277

CollectionAssert.AreEqual(expected: CustomModifiersTestCase.customModifiers[typeNameWithoutSuffix].Reverse(), actual: modreqs);
CollectionAssert.AreEqual(expected: Enumerable.Reverse(CustomModifiersTestCase.customModifiers[typeNameWithoutSuffix]), actual: modreqs);
// ^ see comment about `.Reverse()` above.
}

Expand All @@ -205,7 +205,7 @@ public void ReflectionReturnsCorrectModoptOnReturnTypeForGeneratedType(string ty
var modopts = this.generatedTypes[typeName].GetMethod("Foo").ReturnParameter.GetOptionalCustomModifiers();
Assume.That(modopts.Length > 0); // If this fails on mono/linux we have to revisit the commits and issues for IL method custom modifiers. https://github.com/castleproject/Core/issues/277

CollectionAssert.AreEqual(expected: CustomModifiersTestCase.customModifiers[typeNameWithoutSuffix].Reverse(), actual: modopts);
CollectionAssert.AreEqual(expected: Enumerable.Reverse(CustomModifiersTestCase.customModifiers[typeNameWithoutSuffix]), actual: modopts);
// ^ see comment about `.Reverse()` above.
}

Expand All @@ -227,7 +227,7 @@ public void ReflectionReturnsCorrectModreqOnReturnTypeForGeneratedType(string ty
var modreqs = this.generatedTypes[typeName].GetMethod("Foo").ReturnParameter.GetRequiredCustomModifiers();
Assume.That(modreqs.Length > 0); // If this fails on mono/linux we have to revisit the commits and issues for IL method custom modifiers. https://github.com/castleproject/Core/issues/277

CollectionAssert.AreEqual(expected: CustomModifiersTestCase.customModifiers[typeNameWithoutSuffix].Reverse(), actual: modreqs);
CollectionAssert.AreEqual(expected: Enumerable.Reverse(CustomModifiersTestCase.customModifiers[typeNameWithoutSuffix]), actual: modreqs);
// ^ see comment about `.Reverse()` above.
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public FieldBuilder FieldBuilder

public FieldInfo Reference
{
get { return field; }
get { return @field; }
Comment thread
stakx marked this conversation as resolved.
}

public override void LoadAddressOfReference(ILGenerator gen)
Expand Down
Loading