Recover auto-review reads from corrupt index#134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of #130. The indexed auto-review store should keep read paths durable: if the scoped
runs.jsonindex is corrupt or unreadable, users should still be able to see recoverable run history from scoped output sidecars and legacy runs. At the same time, mutation paths should not silently write through a corrupt index and risk discarding index-only state.What
list_runs,load_run, finding detail, duplicate lookup).healthy scoped index > scoped sidecar > legacy, including corrupt-index fallback where scoped sidecars beat stale legacy records.Verification
cargo test -p codex-auto-review corrupt_index -- --nocapturecargo test -p codex-auto-reviewcargo fmt --all --checkgit diff --check