Skip to content

Persist Odoo override payloads into web runtime env#1291

Merged
cbusillo merged 2 commits into
mainfrom
odoo-web-override-handoff
Jun 13, 2026
Merged

Persist Odoo override payloads into web runtime env#1291
cbusillo merged 2 commits into
mainfrom
odoo-web-override-handoff

Conversation

@cbusillo

Copy link
Copy Markdown
Owner

Summary

  • expose the typed Odoo override payload and required flags in the raw compose env anchor used by web and script-runner
  • persist deploy-phase override payloads into Dokploy target env before web redeploy, with provider readback checks and stale-key cleanup
  • fail stable target replacement before deploy when a secret-backed override references missing neutral secret env keys
  • document the runtime handoff and fail-closed provider readback behavior

Tests

  • uv run python -m unittest tests.test_dokploy tests.test_odoo_instance_overrides tests.test_odoo_stable_target_replacement
  • uv run --extra dev ruff format --check control_plane/dokploy.py control_plane/odoo_instance_overrides.py control_plane/workflows/odoo_stable_target_replacement.py tests/test_dokploy.py tests/test_odoo_instance_overrides.py tests/test_odoo_stable_target_replacement.py
  • uv run --extra dev ruff check --diff control_plane/dokploy.py control_plane/odoo_instance_overrides.py control_plane/workflows/odoo_stable_target_replacement.py tests/test_dokploy.py tests/test_odoo_instance_overrides.py tests/test_odoo_stable_target_replacement.py
  • uv run --extra dev ruff check control_plane/dokploy.py control_plane/odoo_instance_overrides.py control_plane/workflows/odoo_stable_target_replacement.py tests/test_dokploy.py tests/test_odoo_instance_overrides.py tests/test_odoo_stable_target_replacement.py

Review

Focused review agents found stale target-env cleanup and missing secret-env predeploy validation gaps; both are addressed in this PR with tests.

Companion

Pairs with cbusillo/odoo-devkit#68, which adds the Odoo-side fail-closed runtime guards for these flags.

@cbusillo cbusillo merged commit 691a124 into main Jun 13, 2026
12 checks passed
@cbusillo cbusillo deleted the odoo-web-override-handoff branch June 13, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant