Migrate inventory read to FastAPI#1384
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /v1/inventory/{context}/{instance}route with typed response and OpenAPI contract coverageinventory.readagainst the path context before store access, then verify the stored inventory context before returning the recordRefs #1322
Validation
uv run python -m unittest tests.test_http_app.FastApiEnvironmentInventoryReadTests tests.test_service.LaunchplaneServiceTests.test_single_record_read_routes_are_retired_from_legacy_wsgi_appuv run python -m unittest tests.test_http_app tests.test_serviceuv run python -m unittestuv run --extra dev ruff check --diff .uv run --extra dev ruff check .uv run --extra dev ruff check control_plane/http_app.py control_plane/service.py tests/test_http_app.py tests/test_service.pyuv run --extra dev ruff format --check control_plane/http_app.py control_plane/service.py tests/test_http_app.py tests/test_service.pyuv run --extra dev mypy control_plane testsNotes
uv run --extra dev ruff format --check .still reports 56 unrelated pre-existing files that would reformat; changed Python files are formatted.