toggleswitch: стилизация, сторисы, обёртки#19
Open
khaliulin wants to merge 5 commits intofeature/styles-debugfrom
Open
toggleswitch: стилизация, сторисы, обёртки#19khaliulin wants to merge 5 commits intofeature/styles-debugfrom
khaliulin wants to merge 5 commits intofeature/styles-debugfrom
Conversation
ichiesov
requested changes
Apr 14, 2026
| selector: 'toggleswitch', | ||
| standalone: true, | ||
| imports: [ToggleSwitch, FormsModule], | ||
| providers: [ |
Collaborator
There was a problem hiding this comment.
Нужны еще Form Validators, на случай если необходимы валидации формы
Author
Comment on lines
+29
to
+30
| @Input() invalid = false; | ||
| @Input() disabled = false; |
Collaborator
There was a problem hiding this comment.
invalid и disabled должны считытваться через FormControl
Апи использования должно быть такое
const control = new FormControl({value: false, disabled: true}, [Validators.required])
control.enable();
control.disable();
control.setErrors({invalid: true});
все через формы, не прокидывая пропсы
Author
ichiesov
reviewed
Apr 14, 2026
Collaborator
ichiesov
left a comment
ichiesov
left a comment
There was a problem hiding this comment.
Нужна экспертиза с точки зрения UI
Мне кажется, что визуал состояния hover и checked не соответствует фигме.
khaliulin
force-pushed
the
form.inputswitch
branch
from
7bdea8a to
413a903
Compare
Author
|
@ichiesov отображение корректное #19 (review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.