confirm-dialog: стилизация, сторисы, обёртки#33
Open
khaliulin wants to merge 6 commits intooverlay.dialogfrom
Open
confirm-dialog: стилизация, сторисы, обёртки#33khaliulin wants to merge 6 commits intooverlay.dialogfrom
khaliulin wants to merge 6 commits intooverlay.dialogfrom
Conversation
AxyIX
reviewed
Apr 13, 2026
| imports: [ConfirmDialog, Button, PrimeTemplate], | ||
| template: ` | ||
| <p-confirmDialog [key]="key" [styleClass]="computedClass" appendTo="body"> | ||
| <ng-template pTemplate="headless" let-message let-onAccept="onAccept" let-onReject="onReject"> |
Collaborator
There was a problem hiding this comment.
мы не планируем кастомизаций этого диалога?
AxyIX
reviewed
Apr 13, 2026
| selector: 'app-confirm-dialog-default', | ||
| standalone: true, | ||
| imports: [ConfirmDialogComponent, Button], | ||
| providers: [ConfirmationService], |
Collaborator
There was a problem hiding this comment.
у нас должен быть свой сервис для работа с этим комонентом. под капотом он может использовать праймовский сервис.
AxyIX
reviewed
Apr 13, 2026
| <ng-template pTemplate="headless" let-message let-onAccept="onAccept" let-onReject="onReject"> | ||
| <div class="p-dialog-header"> | ||
| <div class="p-dialog-title"> | ||
| <i [class]="message.icon + ' p-icon'"></i> |
Collaborator
There was a problem hiding this comment.
думаю праймовский класс иконки не нужен
… у кнопки отклонения
AxyIX
reviewed
Apr 15, 2026
| <i [class]="message.icon"></i> | ||
| <span>{{ message.header }}</span> | ||
| </div> | ||
| <button |
Collaborator
There was a problem hiding this comment.
кнопки должны быть наши, иначе всё сломается если прайм выпилим из под капота.
AxyIX
reviewed
Apr 15, 2026
| selector: 'app-confirm-dialog-default', | ||
| standalone: true, | ||
| imports: [ConfirmDialogComponent, Button], | ||
| providers: [ConfirmationService, ConfirmDialogService], |
Collaborator
There was a problem hiding this comment.
тут также - при использовании нашего компонента/сервиса мы не должны ничего знать про прайм. нужно что бы всё взаимодействие шло через наш сервис, а уже наш сервис может работать с сервисом прайма.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.