ledgerlib minor reorg#5
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors CelerLedger to remove the LedgerBalanceLimit library hop by inlining balance-limit admin and several config getters directly into the CelerLedger contract, and updates documentation + gas baselines to reflect the new layout.
Changes:
- Inline balance-limit admin (
setBalanceLimits/ enable/disable + getters) intoCelerLedgerand removeLedgerBalanceLimit.sol. - Inline ledger-wide config getters (
getNativeWrap/getPayRegistry/getCelerWallet) intoCelerLedgerand remove the corresponding library getters fromLedgerOperation. - Refresh gas report baselines and update docs/scripts to reflect “3 ledger libraries” deployment model.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/gas_logs/fine_granularity/IntendSettle-OneState.txt | Updates recorded gas baselines after the ledgerlib reorg. |
| test/gas_logs/fine_granularity/DepositEthInBatch.txt | Updates recorded gas baselines after the ledgerlib reorg. |
| test/gas_logs/fine_granularity/ClearPays.txt | Updates recorded gas baselines after the ledgerlib reorg. |
| test/gas_logs/CelerLedger-ETH.txt | Updates deploy/call gas baselines reflecting reduced overhead. |
| test/gas_logs/CelerLedger-ERC20.txt | Updates call gas baselines reflecting reduced overhead. |
| src/lib/ledgerlib/LedgerOperation.sol | Removes config getter wrappers now handled directly by CelerLedger. |
| src/lib/ledgerlib/LedgerBalanceLimit.sol | Removes the balance-limit library (logic moved into CelerLedger). |
| src/interfaces/ICelerLedger.sol | Updates interface-level documentation to match the new implementation grouping. |
| src/CelerLedgerMock.sol | Drops unused LedgerBalanceLimit import after library removal. |
| src/CelerLedger.sol | Inlines balance-limit admin + config getters; removes using LedgerBalanceLimit. |
| script/README.md | Updates deployment/verification docs for one fewer deployed ledger library. |
| docs/contracts.md | Updates architecture docs and bytecode-size discussion to match the new split. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.