Skip to content

ledgerlib minor reorg#5

Merged
hhl42 merged 2 commits into
mainfrom
ledgerlib-reorg
May 8, 2026
Merged

ledgerlib minor reorg#5
hhl42 merged 2 commits into
mainfrom
ledgerlib-reorg

Conversation

@hhl42

@hhl42 hhl42 commented May 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors CelerLedger to remove the LedgerBalanceLimit library hop by inlining balance-limit admin and several config getters directly into the CelerLedger contract, and updates documentation + gas baselines to reflect the new layout.

Changes:

  • Inline balance-limit admin (setBalanceLimits / enable/disable + getters) into CelerLedger and remove LedgerBalanceLimit.sol.
  • Inline ledger-wide config getters (getNativeWrap / getPayRegistry / getCelerWallet) into CelerLedger and remove the corresponding library getters from LedgerOperation.
  • Refresh gas report baselines and update docs/scripts to reflect “3 ledger libraries” deployment model.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/gas_logs/fine_granularity/IntendSettle-OneState.txt Updates recorded gas baselines after the ledgerlib reorg.
test/gas_logs/fine_granularity/DepositEthInBatch.txt Updates recorded gas baselines after the ledgerlib reorg.
test/gas_logs/fine_granularity/ClearPays.txt Updates recorded gas baselines after the ledgerlib reorg.
test/gas_logs/CelerLedger-ETH.txt Updates deploy/call gas baselines reflecting reduced overhead.
test/gas_logs/CelerLedger-ERC20.txt Updates call gas baselines reflecting reduced overhead.
src/lib/ledgerlib/LedgerOperation.sol Removes config getter wrappers now handled directly by CelerLedger.
src/lib/ledgerlib/LedgerBalanceLimit.sol Removes the balance-limit library (logic moved into CelerLedger).
src/interfaces/ICelerLedger.sol Updates interface-level documentation to match the new implementation grouping.
src/CelerLedgerMock.sol Drops unused LedgerBalanceLimit import after library removal.
src/CelerLedger.sol Inlines balance-limit admin + config getters; removes using LedgerBalanceLimit.
script/README.md Updates deployment/verification docs for one fewer deployed ledger library.
docs/contracts.md Updates architecture docs and bytecode-size discussion to match the new split.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/interfaces/ICelerLedger.sol Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@hhl42 hhl42 merged commit 6058fd0 into main May 8, 2026
2 checks passed
@hhl42 hhl42 deleted the ledgerlib-reorg branch May 8, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants