Add generic-webhook-trigger to ceph/ceph PR jobs for ci-approved label - #2671
Open
djgalloway wants to merge 1 commit into
Open
Add generic-webhook-trigger to ceph/ceph PR jobs for ci-approved label#2671djgalloway wants to merge 1 commit into
djgalloway wants to merge 1 commit into
Conversation
djgalloway
force-pushed
the
add-ci-approved-webhook-trigger
branch
2 times, most recently
from
July 31, 2026 15:16
97c2492 to
4d0f44a
Compare
Every job that uses the github-pull-request (ghprb) trigger against ceph/ceph now also accepts a generic-webhook-trigger (like ceph-trigger-build) so a build can be triggered by adding a "ci-approved" label to a pull request. The trigger filters on the pull_request "labeled" event with label name "ci-approved" and contributes the ghprb-equivalent variables (ghprbPullId, ghprbTargetBranch, ghprbSourceBranch, ghprbActualCommit, sha1) from the webhook payload so the existing SCM sections and build scripts resolve as before. All jobs share the ci-approved-trigger-token credential (a Secret Text credential holding a random token, same model as ceph-trigger-build), so a single ceph/ceph webhook pointed at /generic-webhook-trigger/invoke?token=<secret> fans out to all of these jobs when the label is added. All definitions validated with jenkins-jobs test. Signed-off-by: David Galloway <david.galloway@ibm.com>
djgalloway
force-pushed
the
add-ci-approved-webhook-trigger
branch
from
July 31, 2026 15:20
4d0f44a to
c99f9d2
Compare
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every active job that runs on `ceph/ceph` pull requests via the `github-pull-request` (ghprb) trigger now also accepts a `generic-webhook-trigger` (modeled on `ceph-trigger-build`), so a build can be triggered by adding a `ci-approved` label to the PR. 13 definition files:
ceph-pull-requests, ceph-pull-requests-arm64, ceph-pr-api, ceph-pr-commits, ceph-pr-submodules, ceph-pr-docs, ceph-dashboard-pull-requests, ceph-dashboard-cephadm-e2e, ceph-perf-pull-requests, ceph-rook-e2e, ceph-volume-unit-tests, ceph-volume-cephadm-prs, ceph-windows-pull-requests
Jobs watching other repos are intentionally not included.
How it works
Before this takes effect
Reviewer notes