Use flightCache for index cache implementation#2175
Open
markusthoemmes wants to merge 1 commit intochainguard-dev:mainfrom
Open
Use flightCache for index cache implementation#2175markusthoemmes wants to merge 1 commit intochainguard-dev:mainfrom
markusthoemmes wants to merge 1 commit intochainguard-dev:mainfrom
Conversation
Currently, there's a race between store, load and forget if indexes get looked up concurrently and change mid-way through the process. The r
ace goes like this:
1. A: HEAD request → gets etag1, key = "url@etag1"
2. A: Once.Do runs: fetches, parses, calls store("url@etag1", idx), then sets urlToEtag[url] = etag1
3. B: HEAD request → gets etag2 (index was updated server-side), key = "url@etag2"
4. B: Once.Do runs: sees prev = etag1, calls forget("url@etag1") — which deletes indexes["url@etag1"]
5. A: calls load("url@etag1") → key not found → consistency error
Using the inFlight cache fixes that as values are not stored and loaded separately.
Separately, there's another race where we'd leak indexes with outdated etags if two HEAD requests would race outside of the critical section of adjusting the etag pointers. That's fixed through forgetting all "old" etag values for a given index URL as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there's a race between store, load and forget if indexes get looked up concurrently and change mid-way through the process. The r ace goes like this:
Using the inFlight cache fixes that as values are not stored and loaded separately.
Separately, there's another race where we'd leak indexes with outdated etags if two HEAD requests would race outside of the critical section of adjusting the etag pointers. That's fixed through forgetting all "old" etag values for a given index URL as well.