fix(policies): handle 401/403 from policy provider as unauthorized error#2962
Merged
migmartri merged 3 commits intochainloop-dev:mainfrom Mar 30, 2026
Merged
Conversation
Previously, HTTP 401/403 responses from policy providers were returned as generic errors, falling through to LogAndMaskErr which masked them from the client. Now they surface as proper unauthorized errors with descriptive messages. Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Read the response body from the policy provider and include it in the error so the caller sees the actual reason for the rejection instead of a bare sentinel. Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Upstream policy providers return structured JSON with a reason field. Parse the response body and extract the reason for a clearer error message instead of dumping the raw JSON blob. Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
jiparis
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrUnauthorizedsentinel error in the policies package for HTTP 401/403 responses from policy providersbiz.ErrUnauthorizedinGetPolicy,GetPolicyGroup, andValidatePolicyAttachmentso it surfaces as a gRPCPERMISSION_DENIEDwith a descriptive message instead of being masked as an internal errorResolve,ResolveGroup, andValidateAttachment