Remove APIs and group single entrypoint#109
Merged
Merged
Conversation
Andarist
previously approved these changes
Jun 15, 2026
bluwy
commented
Jun 16, 2026
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Andarist
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to propose some breaking changes:
Removed
commitFilesFromBuffersandcommitFilesFromDirectory. Through the recent refactors, you can see that they're a thin wrapper over the corecommitFilesFromBase64.I don't think it's hard for users to use
commitFilesFromBase64directly, so I'd prefer if we consolidate to that.Remove subpath exports, only use the main
"."entrypoint.With exports conditions, it should be possible to split the API for browsers and node in the same subpath. Plus treeshaking works the same with this approach. You get the same small bundle size already if you only use one set of APIs.
Maybe I'd rename
commitFilesFromBase64to something more user-friendly I think, but I'd like to focus on the API trimming for now.