Fix gunicorn logging in docker#390
Open
deepanshutiwari27 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Deepanshu Tiwari <tiwarideepanshu235@gmail.com>
deepanshutiwari27
force-pushed
the
fix-issue-374
branch
from
15d07bf to
09fd295
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the Docker Gunicorn logging fix for CollectOSS #374.
Root cause: Docker already relies on gunicorn_conf.py setting errorlog = '-', but both CLI startup paths passed --log-file, which overrides the config and sends Gunicorn errors only to the file. Docker then has nothing useful to show via docker logs.
Changes:
Added internal Gunicorn command builder: collectoss/application/cli/_gunicorn.py (line 17)
Updated backend startup to omit --log-file in Docker: collectoss/application/cli/backend.py (line 108)
Updated API startup the same way: collectoss/application/cli/api.py (line 65)
Switched Gunicorn config to the current Docker env name and kept errorlog = '-': collectoss/api/gunicorn_conf.py (line 45)
Added focused regression tests: tests/test_application/test_cli/test_gunicorn_command.py (line 7)
Fixes #374