Security: Incorrect Fallback Value for Number.MIN_SAFE_INTEGER - #3479
Open
tomaioo wants to merge 1 commit into
Open
Security: Incorrect Fallback Value for Number.MIN_SAFE_INTEGER#3479tomaioo wants to merge 1 commit into
tomaioo wants to merge 1 commit into
Conversation
The fallback value for `Number.MIN_SAFE_INTEGER` is calculated as `-(2 ** 53) - 1`, which evaluates to `-9007199254740993`. However, the correct value for `Number.MIN_SAFE_INTEGER` is `-9007199254740992` (i.e., `-(2 ** 53) + 1` or `-(2 ** 53 - 1)`). This off-by-one error results in an incorrect constant being used in environments where `Number.MIN_SAFE_INTEGER` is not natively defined. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Incorrect Fallback Value for Number.MIN_SAFE_INTEGER
Problem
Severity:
Medium| File:src/internal/ponyfills/Number.MIN_SAFE_INTEGER.js:L1The fallback value for
Number.MIN_SAFE_INTEGERis calculated as-(2 ** 53) - 1, which evaluates to-9007199254740993. However, the correct value forNumber.MIN_SAFE_INTEGERis-9007199254740992(i.e.,-(2 ** 53) + 1or-(2 ** 53 - 1)). This off-by-one error results in an incorrect constant being used in environments whereNumber.MIN_SAFE_INTEGERis not natively defined.Solution
Fix the fallback calculation to
-(2 ** 53 - 1)or-(2 ** 53) + 1to ensure the correct value forNumber.MIN_SAFE_INTEGERis used.Changes
src/internal/ponyfills/Number.MIN_SAFE_INTEGER.js(modified)