FAQ/Charge Control C: add note about Modbus and ignore_echo#92
Open
barsnick wants to merge 4 commits intoeverest/charge_control_cfrom
Open
FAQ/Charge Control C: add note about Modbus and ignore_echo#92barsnick wants to merge 4 commits intoeverest/charge_control_cfrom
ignore_echo#92barsnick wants to merge 4 commits intoeverest/charge_control_cfrom
Conversation
Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
mhei
approved these changes
Apr 2, 2026
Member
mhei
left a comment
mhei
left a comment
There was a problem hiding this comment.
I'd drop "i.MX6", otherwise fine.
t-mon
approved these changes
Apr 2, 2026
Member
|
Thanks for addressing this. But i'm not really happy with the location because the proper settings should be documented at places before the issue occur. On Charge SOM we already addressed this here So I would be happy place it for Charge Control C at the equivalent chapter. |
lategoodbye
requested changes
Apr 2, 2026
Member
lategoodbye
left a comment
lategoodbye
left a comment
There was a problem hiding this comment.
Please place it similiar to the Charge SOM (see my other comment).
This reverts commit 5c915ce.
Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
Contributor
Author
|
Moved to "Hardware" section. Local echo documented in table and amended with a footnote. (Must squash for merge.) |
lategoodbye
approved these changes
Apr 2, 2026
mhei
approved these changes
Apr 2, 2026
t-mon
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.