Skip to content

feat(ui): add skills discovery status to sidebar and landing page#2384

Merged
andreynering merged 5 commits intocharmbracelet:mainfrom
huaiyuWangh:feat/skills-sidebar
Apr 16, 2026
Merged

feat(ui): add skills discovery status to sidebar and landing page#2384
andreynering merged 5 commits intocharmbracelet:mainfrom
huaiyuWangh:feat/skills-sidebar

Conversation

@huaiyuWangh
Copy link
Copy Markdown
Contributor

@huaiyuWangh huaiyuWangh commented Mar 9, 2026 •
edited
Loading

Summary

  • Add a new Skills section to the sidebar and landing page, showing loaded/errored skills with status icons (consistent with existing LSP/MCP sections)
  • Introduce pubsub-based refresh: Discover() publishes skill states via broker event, UI subscribes and updates automatically

Test plan

  • go vet passes on all changed packages
  • go test ./internal/skills/... passes (including new event-based assertions)
  • Manually verify sidebar and landing page show skills section with correct icons
  • Verify skills section updates automatically when discovery completes
image image

@huaiyuWangh huaiyuWangh requested a review from a team as a code owner March 9, 2026 06:04
@huaiyuWangh huaiyuWangh requested review from meowgorithm and raphamorim and removed request for a team March 9, 2026 06:04
@huaiyuWangh huaiyuWangh force-pushed the feat/skills-sidebar branch from 8543e9c to 55bb2d2 Compare March 9, 2026 06:36
@meowgorithm
Copy link
Copy Markdown
Member

meowgorithm commented Mar 12, 2026

Very nice. Haven't vetted the code yet, but overall this is a great feature.

@huaiyuWangh huaiyuWangh force-pushed the feat/skills-sidebar branch from 55bb2d2 to f4b3ea6 Compare March 16, 2026 12:37
@meowgorithm meowgorithm requested review from aymanbagabas and removed request for raphamorim March 16, 2026 13:22
@meowgorithm
Copy link
Copy Markdown
Member

meowgorithm commented Mar 23, 2026

@Amolith I believe this is in line with what you mentioned the other day.

@huaiyuWangh we intend to merge this: thanks for your patience with this one (as well as with your other, excellent PRs).

@meowgorithm meowgorithm force-pushed the feat/skills-sidebar branch from eb3cc83 to 999028a Compare April 12, 2026 20:44
@meowgorithm
Copy link
Copy Markdown
Member

meowgorithm commented Apr 12, 2026 •
edited
Loading

Thanks for your patience with this @huaiyuWangh. This is a great feature. Pending @andreynering's review we'll merge this.

Some other changes I made:

  • Skills are also shown in the overlay in compact mode
  • Builtin skills are also shown
  • We now use up the available space in the sidebar to show files, mcps, lsps, and skills

andreynering
andreynering approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @huaiyuWangh!

We have a conflict. Can you fix so we can merge?

@huaiyuWangh huaiyuWangh force-pushed the feat/skills-sidebar branch 2 times, most recently from e306803 to 8b893a0 Compare April 14, 2026 11:57
huaiyuWangh and others added 5 commits April 14, 2026 20:01
@huaiyuWangh
feat(ui): add skills discovery status to sidebar and landing page
c368fb6 
- Display loaded/errored skills in sidebar and landing page
- Use pubsub event to carry skill states directly to UI, avoiding
  global mutable state
- Subscribe to skills discovery events via broker, consistent with
  MCP/LSP patterns
- Rename State to DiscoveryState for clarity
@meowgorithm @huaiyuWangh
fix: overflow arithmetic (off-by-one)
7b4180c
@meowgorithm @huaiyuWangh
chore(ui/sidebar): use available space for flies, lsp, mcps, and skills
a222907
@meowgorithm @huaiyuWangh
feat(ui/compact): show skills in status overlay in compact mode
d9d96ee
@meowgorithm @huaiyuWangh
chore(ui): sort builtin skills with other skills
23cb495
@huaiyuWangh huaiyuWangh force-pushed the feat/skills-sidebar branch from 8b893a0 to 23cb495 Compare April 14, 2026 12:14
@huaiyuWangh
Copy link
Copy Markdown
Contributor Author

huaiyuWangh commented Apr 14, 2026

Hi @andreynering, I’ve resolved the rebase conflicts, and tests are passing locally. Everything appears to be working as expected.

Since quite some time has passed, I’m a bit concerned there could be subtle interactions with newer features. It would be great if you could give it another review before merge.

@meowgorithm
Copy link
Copy Markdown
Member

meowgorithm commented Apr 14, 2026

Fwiw @huaiyuWangh and @andreynering, I spent some time with this the other day and got it to up to date with the current codebase and new features. I believe it's in good shape and I stand by it.

@andreynering
Copy link
Copy Markdown
Member

andreynering commented Apr 16, 2026

Let's get this in. Thank you @huaiyuWangh!!

@andreynering andreynering merged commit b37649e into charmbracelet:main Apr 16, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meowgorithm meowgorithm meowgorithm approved these changes

@andreynering andreynering andreynering approved these changes

@aymanbagabas aymanbagabas Awaiting requested review from aymanbagabas

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huaiyuWangh @meowgorithm @andreynering