Skip to content

chore: fix mise worktree support and cleanup#4

Open
amondnet wants to merge 1 commit into
mainfrom
amondnet/minsu-lee/chore-fix-mise-and-commitlint-v2
Open

chore: fix mise worktree support and cleanup#4
amondnet wants to merge 1 commit into
mainfrom
amondnet/minsu-lee/chore-fix-mise-and-commitlint-v2

Conversation

@amondnet

@amondnet amondnet commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • mise setup 태스크에 worktree 감지 추가 (worktree에서 hook 설치 스킵)
  • main에서 .mjs로 마이그레이션된 commitlint.config.js 삭제
  • .please/state/.gitignore에 추가
  • agent memory 파일 추가

Test plan

  • mise run setup 이 worktree와 일반 repo에서 모두 동작 확인
  • commitlint가 .mjs 설정으로 정상 동작 확인

Summary by cubic

Add worktree detection to mise setup so commit hooks are not installed in Git worktrees. Also remove stale commitlint.config.js, ignore .please/state/, and add agent memory docs.

  • Bug Fixes

    • Update .mise.toml: mise run setup installs the commit-msg hook only when a .git directory exists; prints a skip message in worktrees.
  • Refactors

    • Remove commitlint.config.js (migrated to .mjs on main).
    • Add .please/state/ to .gitignore.
    • Add .claude/agent-memory docs (no runtime impact).

Written for commit 28cedcb. Summary will update on new commits.

- Add worktree detection to mise setup task
- Remove commitlint.config.js (migrated to .mjs on main)
- Add .please/state/ to .gitignore
- Add agent memory files
@amondnet amondnet self-assigned this Mar 24, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Architecture diagram
sequenceDiagram
    participant Dev as Developer / CI
    participant Mise as Mise Runner
    participant FS as File System
    participant Hook as Git Hook Store
    participant CL as Commitlint CLI

    Note over Dev,CL: NEW: Mise Setup Flow (mise run setup)
    
    Dev->>Mise: mise run setup
    Mise->>FS: Run bun install
    Mise->>FS: NEW: Check for .git/ directory
    
    alt .git directory exists (Standard Repository)
        FS-->>Mise: Directory found
        Mise->>Hook: NEW: mise generate git-pre-commit (commit-msg)
        Hook-->>Mise: Write hook file
        Mise-->>Dev: Setup complete
    else .git directory missing (Git Worktree)
        FS-->>Mise: Directory not found
        Mise-->>Dev: NEW: Log "Skipping hook setup (worktree detected)"
    end

    Note over Dev,CL: Commit Execution Flow
    
    Dev->>Hook: git commit
    Hook->>CL: Trigger commit-msg task
    CL->>FS: CHANGED: Search for configuration
    Note right of FS: commitlint.config.js (REMOVED)
    FS-->>CL: Load commitlint.config.mjs
    CL-->>Dev: Validation result (Success/Fail)

    Note over Dev,FS: External State / Documentation
    Note over Dev,FS: .gitignore updated to exclude .please/state/
    Note over Dev,FS: Agent memory docs added for Firestore Adapter patterns
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant