chore: fix mise worktree support and cleanup#4
Open
amondnet wants to merge 1 commit into
Open
Conversation
- Add worktree detection to mise setup task - Remove commitlint.config.js (migrated to .mjs on main) - Add .please/state/ to .gitignore - Add agent memory files
There was a problem hiding this comment.
No issues found across 7 files
Architecture diagram
sequenceDiagram
participant Dev as Developer / CI
participant Mise as Mise Runner
participant FS as File System
participant Hook as Git Hook Store
participant CL as Commitlint CLI
Note over Dev,CL: NEW: Mise Setup Flow (mise run setup)
Dev->>Mise: mise run setup
Mise->>FS: Run bun install
Mise->>FS: NEW: Check for .git/ directory
alt .git directory exists (Standard Repository)
FS-->>Mise: Directory found
Mise->>Hook: NEW: mise generate git-pre-commit (commit-msg)
Hook-->>Mise: Write hook file
Mise-->>Dev: Setup complete
else .git directory missing (Git Worktree)
FS-->>Mise: Directory not found
Mise-->>Dev: NEW: Log "Skipping hook setup (worktree detected)"
end
Note over Dev,CL: Commit Execution Flow
Dev->>Hook: git commit
Hook->>CL: Trigger commit-msg task
CL->>FS: CHANGED: Search for configuration
Note right of FS: commitlint.config.js (REMOVED)
FS-->>CL: Load commitlint.config.mjs
CL-->>Dev: Validation result (Success/Fail)
Note over Dev,FS: External State / Documentation
Note over Dev,FS: .gitignore updated to exclude .please/state/
Note over Dev,FS: Agent memory docs added for Firestore Adapter patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mjs로 마이그레이션된commitlint.config.js삭제.please/state/를.gitignore에 추가Test plan
mise run setup이 worktree와 일반 repo에서 모두 동작 확인.mjs설정으로 정상 동작 확인Summary by cubic
Add worktree detection to
misesetup so commit hooks are not installed in Git worktrees. Also remove stalecommitlint.config.js, ignore.please/state/, and add agent memory docs.Bug Fixes
.mise.toml:mise run setupinstalls thecommit-msghook only when a.gitdirectory exists; prints a skip message in worktrees.Refactors
commitlint.config.js(migrated to.mjsonmain)..please/state/to.gitignore..claude/agent-memorydocs (no runtime impact).Written for commit 28cedcb. Summary will update on new commits.