test: update deltachat 2.50 compatibility in relay_minitest#21
test: update deltachat 2.50 compatibility in relay_minitest#21ccclxxiii wants to merge 6 commits into
Conversation
|
CI is not running the tests because lint failed. |
thanks, addressed in |
| pw = user2.get_config("mail_pw") | ||
|
|
||
| addr = user1.get_config("addr") | ||
| host = addr.split("@")[1].strip("[").strip("]") |
There was a problem hiding this comment.
Maybe you wanted .lstrip("[").rstrip("]"). .strip("[]") was working too.
| host = addr.split("@")[1].strip("[]") | ||
| pw = user2.get_config("mail_pw") | ||
|
|
||
| addr = user1.get_config("addr") |
There was a problem hiding this comment.
This now takes addr of user1, so mailbox of user1 is checked below. But chat = cmfactory.get_accepted_chat(user1, user2) returns the chat of user1 above, so chat.send_text("testing submission header cleanup") sends a message from user1 to user2.
I guess it will pass, but by enabling bcc_self on user1 you now read the copy user1 sent to self from the mailbox. Previously the test was testing that user2 (receiver of the message) does not see IP of user1, now the test is testing that user1 does not see own IP in the copy it sent to self.
| deadline = time.time() + 10 | ||
| msgs = [] | ||
|
|
||
| while time.time() < deadline: |
There was a problem hiding this comment.
This loop was not necessary when user2 was checking the mailbox of user2 because by this time we know user2 has received the message (user2.wait_for_incoming_msg() above).
I think the only change needed overall is enabling bcc_self on user2 so user2 does not delete the message immediately, that's all.
There was a problem hiding this comment.
@link2xt thanks, took a stab at it in 1381f2087f74adb844c1649254faeefefb45cd61
2 participants
summary
this updates the bundled
relay_minitesttest setup for compatibility with deltachat rpc/server 2.50.0.changes
remove unsupported deltachat config
the bundled minitest account setup previously configured:
deltachat rpc/server 2.50.0 now rejects this key with:
which caused
test-miniaccount setup to fail before tests could run.the unsupported setting has been removed/commented out.
improve sender ip cleanup test handling
test_hide_senders_ip_addresswas updated to reduce timing sensitivity during raw imap inspection by:INBOXcriteria="ALL"bcc_selfrelease note
chatmail/relaycurrently pins reusable workflows andcmlxc_versionto releasedcmlxctags.to consume these fixes from relay ci, a new
cmlxcrelease/tag should be cut and referenced from relay workflows instead of olderv0.14.6pins.until a new release exists, relay ci must temporarily pin to a specific commit sha containing these changes.