fix: fixate madmail to the last Go version #23
Merged
Merged
Conversation
…anging on the upstream repo
|
Removed the cache and restarted the tests. |
link2xt
approved these changes
May 29, 2026
link2xt
left a comment
link2xt
left a comment
There was a problem hiding this comment.
Pushed one-line fix, without it cmlxc init failed as source.ref checkout happened too late and go.mod was still not found.
link2xt
changed the title
link2xt
reviewed
May 29, 2026
| self.bash(f"rm -rf {dest}") | ||
| out.print(f" Initial clone of {name} ...") | ||
| self.bash(f"git clone {source.url} {dest}") | ||
| self.bash(f"git clone --branch {source.ref} {source.url} {dest}") |
There was a problem hiding this comment.
This is the line I pushed. Not great that --branch does not work with hashes, for hashes need to use --revision= but then it does not work for tags. --branch at least works for tags and branch names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the madmail branch is currently being heavily refactored, so better to revisit that when the dust settles, and just fixate on the last go-based version.