test: set socket security for IMAP and SMTP to "TLS" in "dclogin"#991
Merged
Conversation
With "default" (like it was for SMTP) or not set (like it was for IMAP), both TLS and STARTTLS are tried. Trying STARTTLS against TLS port is going to timeout because in STARTTLS server talks first, but when connected to TLS port the server waits for TLS client hello and does not send anything. Should not actually matter in tests which connect successfully on the first try because implicit TLS is tried first.
Contributor
Author
|
Related documentation PR: deltachat/interface#92 |
missytake
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With "default" (like it was for SMTP) or not set (like it was for IMAP), both TLS and STARTTLS are tried.
Trying STARTTLS against TLS port is going to timeout because in STARTTLS server talks first,
but when connected to TLS port the server
waits for TLS client hello and does not send anything.
Should not actually matter in tests which connect successfully on the first try because implicit TLS is tried first.