CHEF-34831 - Use appbundler and codescan fixes#341
Open
nikhil2611 wants to merge 3 commits into
Open
Conversation
Simplecov Report
|
Signed-off-by: nikhil2611 <ngupta@progress.com>
nikhil2611
force-pushed
the
nikhil/CHEF-34831-scan-fix
branch
from
90f04a2 to
2232f48
Compare
…windows test pipeline Signed-off-by: nikhil2611 <ngupta@progress.com>
nikhil2611
changed the title
sanghinitin
approved these changes
May 27, 2026
- Simplified binstub_patch.rb to match chef/chef (only GEM_PATH + APPBUNDLER_ALLOW_RVM) - Updated do_setup_environment to use push_runtime_env/set_runtime_env - Fixed do_prepare to use proper /usr/bin/env symlink pattern with do_end cleanup - Reordered do_install: fix_interpreter vendor/bin -> appbundler -> sed binstub_patch - Reference external binstub_patch.rb file instead of inline generation - Removed fix_interpreter on bin/* (not needed, matches chef pattern) Signed-off-by: nikhil2611 <ngupta@progress.com>
nikhil2611
force-pushed
the
nikhil/CHEF-34831-scan-fix
branch
from
583403d to
45535b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request focuses on improving the packaging and installation process for
chef-cli, particularly in Habitat environments, and updates some dependencies. The main changes include refining how binstubs are generated and patched for better compatibility, cleaning up vendored gems to avoid CVE false positives, updating a dependency version, and simplifying the Habitat install script.Packaging and binstub improvements:
plan.shto generate binstubs forchef-cliusingappbundler, added a patch (binstub_patch.rb) to allow running binstubs directly, and replaced the previous wrapper function with a new runtime environment wrapper script. This ensures the correct Ruby and gem environment is set up when runningchef-cliand improves compatibility. (habitat/plan.sh,binstub_patch.rb, [1] [2]binstub_patch.rbautomatically to all generated binstubs in the package. (habitat/plan.sh, habitat/plan.shL66-R114)Vendored gem cleanup:
plan.shand Windowsplan.ps1to remove.githubdirectories from vendored gems, reducing the risk of CVE false positives. (habitat/plan.sh,habitat/plan.ps1, [1] [2]Dependency updates:
addressablegem dependency to require version>= 2.9.0and< 3.0(was< 2.9), improving compatibility and security. (chef-cli.gemspec, chef-cli.gemspecL48-R48)Build/test process improvements:
.expeditor/buildkite/artifact.habitat.test.ps1, [1] [2] [3].expeditor/buildkite/artifact.habitat.test.ps1, .expeditor/buildkite/artifact.habitat.test.ps1L84-L86)Miscellaneous:
chef-clito the list of gems whoseGemfile.lockfiles are cleaned up by thecleanup_lint_roller.rbscript. (cleanup_lint_roller.rb, cleanup_lint_roller.rbL6-R6)Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.