ci: fire lint/CodeQL on release-please PRs#198
Merged
Conversation
Lint and CodeQL were path-filtered to **/*.py only, so release-please PRs (which touch only .release-please-manifest.json, VERSION, and CHANGELOG.md) triggered zero checks. automerge-release.yml then blind-merged them with no CI having run at all. Add the manifest file, VERSION, and each workflow's own file to their paths filters so these PRs actually get linted/scanned.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughCodeQL and lint workflow path filters now trigger on changes to release metadata, ChangesWorkflow trigger updates
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
lint.ymlandcodeql.ymlare path-filtered to**/*.py. A release-pleasePR only touches
.release-please-manifest.json,VERSION, andCHANGELOG.md— none of which match that filter — so those PRs triggerzero status checks.
automerge-release.ymlthen enables auto-merge onthem regardless, meaning release PRs have been merging with no CI having
run at all.
This adds
.release-please-manifest.json,VERSION, and each workflow'sown file to the
paths:filters (mirroring howchodeus/chub'scodeql-lint.ymlincludes.release-please-manifest.json), so a releasePR now fires both checks like any other change.
Why this matters
Once required status checks are configured in branch protection separately,
auto-merge will actually wait on them — but only if the checks fire in the
first place. This PR is the "make CI fire" half of that; it doesn't touch
automerge-release.ymlitself.Job names (for branch-protection required-checks)
lint.yml→ joblintcodeql.yml→ jobanalyzedocker-publish.ymlalso defines jobs namedlintandtest(path-filtered to
Dockerfile/scripts/**/app/**, so it still won'tfire on a release PR) — worth being aware of if these names collide in
the branch-protection required-checks picker.
Ref: portfolio CI-gate audit 2026-07-21.
Summary by CodeRabbit