Support newer versions of Chrome#749
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several parts of the library broke on Chrome versions newer than 122. Chrome 128 and later respond to
Target.closeTargetbefore emittingTarget.targetDestroyed, soPage::close()now waits for the target to actually be destroyed before returning, and headless Chrome 128 to 143 shrinks the viewport by phantom window decorations shortly after startup, so new pages are now pinned to the requested window size (or 800x600) andMouse::findElement()scrolls the element into view and waits for its position to settle instead of dispatching wheel events at a stale target. The tests are adjusted for newer behaviour where Chrome 142 stopped renumbering DOM node ids on reload, Chrome 149 normalizes carriage returns while typing, and the connect-to-browser test now waits for the target created event to arrive. Continuous integration now pairs Chrome 122, 130, 140 and 150 with different Symfony versions so it covers our lowest and highest supported versions without inflating the job count.