fix(ci): fix native library commit workflow#10
Merged
Conversation
Replace incompatible commit action with GitHub API using `actions/github-script` for proper Base64 encoding while maintaining verified commits from the bot. Fixes binary corruption issues in the previous commit workflow as discussed in PR #9.
Remove `.gitattributes` file (from PR #8) which is no longer needed since the GitHub API bypasses git's text transformation logic.
Update artifact uploads when building native libraries to only include native libraries, reducing upload size and focusing on only what's required.
Remove unused exclude rule for native library files that aren't present in the `crates/protect-ffi` directory.
Collaborator
Author
|
Unlike as shown in PR #9, the built and committed libraries are now identical: Prebuilt libraries are, well as you'd expect, working now. |
calvinbrewer
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the native library commit workflow by replacing the current commit action with actions/github-script for proper Base64 encoding while maintaining verified commits from the bot. This fixes binary corruption issues in the previous commit workflow as discussed in PR #9.
Additionally, this PR removes the
.gitattributesfile (from PR #8) since this is no longer needed due to the GitHub API bypassing git's text transformation logic.It also updates artifact uploads when building native libraries to no longer include the READMEs, which will reduce upload size (albeit small) and keep the focus on what's required.
Lastly, it removes an unnecessary exclude rule from
Cargo.tomlfor native library files that aren't present in thecrates/protect-ffidirectory.