fix(bench): reject empty completion markers#186
Open
skyc1e wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A benchmark can leave an empty
summary.csvif it stops after creating the file but before writing its row. The report currently checks only for existence, so that interrupted run is treated as complete and can be used as a baseline.Treat zero-byte summary markers as incomplete. Current results now resolve to
partial, and baseline discovery skips these runs. Added unit coverage for missing, empty, and populated markers plus status resolution.Tests:
cd scripts && python -m unittest test_engine_bench_report.py test_tx_latency_report.py -v