repair cross-compilation of ftype-scheme-object-pointer#1038
Merged
Conversation
Checking whether a parent type represents a Scheme-object ftype pointer used an accessor technique that does not work for cross compilation. Also, repair a documentation typo and a technically too-weak check for consistent record definition.
burgerrg
approved these changes
Apr 27, 2026
Contributor
burgerrg
left a comment
burgerrg
left a comment
There was a problem hiding this comment.
Thank you for finding and fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking whether a parent type represents a Scheme-object ftype pointer used an accessor technique that does not work for cross compilation.
Also, repair a documentation typo and a technically too-weak check for consistent record definition.
Unfortunately, there's not an added test here, because the problem is pretty far outside the current test harness. Detecting the bug requires cross-compilation on a 64-bit platform for a 32-bit platform, and then running in 32-bit mode and loading the cross-compiled program. That could be checked via CI using a Linux host that can run both 32-bit and 64-bit executables, for example, but it seems a lot to add to check this small corner.
There's also not a bug-fix note in "release_notes.stex", because it's a repair to functionality that's new since most recent release.