fix(rdr3/net): fire trail applicability#3848
Open
Ehbw wants to merge 1 commit intocitizenfx:masterfrom
Open
Conversation
github-actions
bot
added
RedM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fixes fire trails updates not being properly replicated across clients. This should fix fire sync between remote clients and it did from testing with a cl2 client with several weapons that created both fire and ignitable trials.
How is this PR achieving the goal
Patch other fire applicability function added in 1491. Which is used in
FIRE_TRAIL_UPDATE_EVENTand alsoFIRE_EVENTin some cases.This PR applies to the following area(s)
RedM
Successfully tested on
Game builds: 1491
Platforms: Windows
Checklist
Fixes issues