tweak(graphics/rdr3): include handle properties when fetching memory type#3880
Open
Ehbw wants to merge 1 commit intocitizenfx:masterfrom
Open
tweak(graphics/rdr3): include handle properties when fetching memory type#3880Ehbw wants to merge 1 commit intocitizenfx:masterfrom
Ehbw wants to merge 1 commit intocitizenfx:masterfrom
Conversation
603f840 to
a0632ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Further improve the external handle import logic for Vulkan. Hopefully should address any remaining cases of
Failed to allocate memory for Vulkan. VkResult: VK_ERROR_OUT_OF_DEVICE_MEMORY A device memory allocation has failed.that's occur on some mobile (laptop) GPU configurations.How is this PR achieving the goal
Introduce assertion to clearly point out if NUI/CEF has given us a null or invalid handle to clearly separate these problems from the error mentioned above.
Change ResultToString default error to be formatted as a signed int32_t as VkResult is signed and all error codes are negative.
Fetch the D3D11 shareHandles memoryTypeBits with _vkGetMemoryWin32HandlePropertiesKHR and takes that into consideration when fetching the memoryType index to be used with allocation
This PR applies to the following area(s)
RedM
Successfully tested on
Game builds: 1491
Platforms: Windows
Checklist
Fixes issues