Upgrade uncrustify from 0.68.1 to 0.82.0#8373
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8373 +/- ##
==========================================
- Coverage 88.94% 88.94% -0.01%
==========================================
Files 287 287
Lines 63150 63154 +4
Branches 7938 7938
==========================================
+ Hits 56171 56174 +3
+ Misses 4669 4668 -1
- Partials 2310 2312 +2 🚀 New features to boost your workflow:
|
This was referenced Dec 7, 2025
naisila
force-pushed
the
naisila/upgrade-uncrustify
branch
4 times, most recently
from
3d5c3fb to
fcf9d2d
Compare
naisila
added a commit
to citusdata/the-process
that referenced
this pull request
Dec 11, 2025
Upgrades uncrustify to 0.82.0 (see below), downgrades pg versions since we will bump versions in Citus _after_ we fix style images. Getting the following error with uncrustify 0.68.1: ``` + cmake .. CMake Error at CMakeLists.txt:1 (cmake_minimum_required): Compatibility with CMake < 3.5 has been removed from CMake. ``` Fix: 0.78.0 is the oldest version with cmake_minimum_required(VERSION 3.5). However, I suggest going with the newest version of uncrustify, 0.82.0, since were gonna update all things anyway, might as well use the newest version. Sister PRs citusdata/citus#8373 citusdata/tools#382
naisila
force-pushed
the
naisila/upgrade-uncrustify
branch
2 times, most recently
from
f808d8e to
477bfce
Compare
naisila
force-pushed
the
naisila/upgrade-uncrustify
branch
from
477bfce to
9c70ad0
Compare
naisila
changed the title
eaydingol
reviewed
Dec 11, 2025
| originalQuery, | ||
| PlannerRestrictionContext | ||
| * | ||
| plannerRestrictionContext, |
Collaborator
There was a problem hiding this comment.
auto change, but does not look better
Contributor
Author
There was a problem hiding this comment.
I agree 😄
So, the indentation right below the opening bracket of the function is something new from uncrustify, couldn't change that.
The star (*) on its own line was there before as well, couldn't find a way to get rid of it.
eaydingol
reviewed
Dec 11, 2025
Collaborator
eaydingol
left a comment
eaydingol
left a comment
There was a problem hiding this comment.
LGTM
thanks for the effort you put into the version update and the manual fixes!
eaydingol
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrade has changed some indentation levels, moved some commas/semicolons to new lines, etc.
I also did some manual style changes to obey the 88-90 character per line rule and avoid commas or semicolons in a new line
Sister PRs citusdata/tools#382 citusdata/the-process#179