feat(tray): live signing-progress pill bar in the menu bar#193
Open
time-attack wants to merge 1 commit into
Open
feat(tray): live signing-progress pill bar in the menu bar#193time-attack wants to merge 1 commit into
time-attack wants to merge 1 commit into
Conversation
…icon Replace the tray icon with a wider canvas during signing: the original Impactor glyph stays put, and a rounded pill track + fill is drawn next to it that grows from 0%->100%. Percent is also written into the icon title (visible next to the icon on macOS). Both clear on finish/error.
Author
this is what it looks like by the way
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_icon) so the pill fills as percent advances;%text is also set viaset_title.Implementation
apps/plumeimpactor/src/tray.rs:set_signing_progress(percent)/clear_signing_progress()onImpactorTray.apps/plumeimpactor/src/screen/mod.rs:ProgressScreenmessage handler drives the tray on everyInstallationProgresstick and clears onInstallationError/InstallationFinished.Test plan
%updates next to the icon