Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple ID sign-in in v2.7.1 can fail with
Authentication SRP error -80046after a valid two-factor code is entered. Althoughmainnow defaults to a Mac Anisette server,AnisetteClient::newstill replaces the server's/v3/client_inforesponse with the hardcoded Windows/iTunes identity. This pairs the remote provider's authentication data with a different client identity.Preserve the server-provided client identity for provisioning and authentication requests. Use a shared
mac_anisette_state.plistfilename so existing provisioning state is not reused after the provider/identity change, update the Settings reset action, and ignore the new state file in Git.The production fix follows the approach proposed in #301 and discussed in #298. This PR adds offline regression coverage, explicit test feature dependencies, and Windows validation. The default server URL is already present in
main; this PR does not change it.Validation
-80046.cargo build --locked --release -j 8 -p plumeimpactor --target x86_64-pc-windows-gnu.main, all three offline regression tests passed:cargo test --locked -j 8 -p plume_core -p omnisette --features plume_core/tweaks --lib -- --skip fetch_anisette. The two existing live Anisette tests are excluded by this filter.cargo check --locked --release -j 8 -p plumeimpactor --target x86_64-pc-windows-gnu.rustfmt;git diff --checkpasses.The local SSC provider path is unchanged. Remote users re-provision once; existing account and certificate files are not removed. Actual macOS/Linux sign-in has not been tested for this PR.
AI assistance
This patch and PR description were prepared with Codex assistance. The reporter manually tested the Windows build and confirmed successful sign-in. This disclosure is included in view of the repository's contribution policy; the code is not represented as manually authored.
Fixes #298.